chore(connd): connection report for troubleshooting#999
Merged
Conversation
…om:worldcoin/orb-software into vm/wwan-dns-resolution-report
sfikastheo
reviewed
Feb 19, 2026
Comment on lines
200
to
203
| let client = reqwest::Client::builder() | ||
| .redirect(reqwest::redirect::Policy::none()) | ||
| .timeout(Duration::from_secs(5)) | ||
| .build()?; |
Contributor
There was a problem hiding this comment.
Can we do this at the top of the report_loop(), and pass it over to the connectivity_check?
From the docs
The Client holds a connection pool internally to improve performance by reusing connections and avoiding setup overhead, so it is advised that you create one and reuse it.
Collaborator
Author
There was a problem hiding this comment.
i wouldn't expect any significant difference here as this is called very infrequently and most of the times most likely with a longer interval than the connection idle timeout.
pushed the change either way though as it won't hurt either
sfikastheo
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds dns resolution and connectivity diagnostics to the network change reporter, to help troubleshoot issues like being stuck on
ConnectedSitewhen connectivity actually works.new
resolved::Resolvedmodule wrapping systemd-resolved'sorg.freedesktop.resolve1d-bus interface viazbus_systemdresolve_hostname(iface, hostname)— resolves a hostname on a specific interface, returns addresses, canonical name, and response flags (cache/network/authenticated/etc)link_status(iface)— per-link dns status: current dns server, all dns servers, search/routing domains, default routenet_changed_reporter::report()added, reporting:resolvectl statusandresolvectl queryresultschanged
ActiveConnnow includesipv4_gateway,ipv4_dns,ipv6_gateway,ipv6_dnsfieldsactive_connections()usesip_interface()instead ofinterface()to get the actual ip-bearing interface (fixes wwan showing ascdc-wdm0instead ofwwan0)